Gens 4 and 5 are the peak of pokmon. Diamond/pearl, platinum AND heartgold/soulsilver for gen 4. And then gen 5 with black/white 1&2.
These were just really solid games with a lot of good extra/optional content. No pokmon game since gen 5 has felt as complete.